-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README with instructions for running with OpenSearch #235
Update README with instructions for running with OpenSearch #235
Conversation
updated README with download and setup instructions for both OpenSearch and Dashboards. Closes #223 Signed-off-by: Bishoy Boktor <[email protected]>
✅ DCO Check Passed f09fab8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just one NIT and question.
Signed-off-by: Bishoy Boktor <[email protected]>
✅ DCO Check Passed da55dfd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
To run OpenSearch Dashboards locally, you first need build artifacts from OpenSearch. | ||
* Clone the OpenSearch Repo [here](https://github.com/opensearch-project/OpenSearch.git) | ||
* Follow installation and setup instructions in the OpenSearch repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just add git clone <>
command here so users may not have to jump the page ???
Signed-off-by: Bishoy Boktor <[email protected]>
✅ DCO Check Passed 4f4bb30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
* Update README with instructions for running with OpenSearch updated README with download and setup instructions for both OpenSearch and Dashboards. Closes #223 Signed-off-by: Bishoy Boktor <[email protected]> * Address PR comments Signed-off-by: Bishoy Boktor <[email protected]> * Address PR comments Signed-off-by: Bishoy Boktor <[email protected]>
…pensearch-project#235) * feature: cannot delete last admin user/group in workspace settings Signed-off-by: yuye-aws <[email protected]> * refactor code with useMemo Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]>
updated README with download and setup instructions for both OpenSearch
and Dashboards.
Closes #223
Signed-off-by: Bishoy Boktor [email protected]